dispatchEvent now takes into account if an element has been disabled. F…

…ixes jsdom#2665
brendo · Oct 9, 2019 · 6922582 · 6922582
1 parent e3744f5
commit 6922582
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/jsdom/living/nodes/HTMLElement-impl.js b/lib/jsdom/living/nodes/HTMLElement-impl.js
@@ -58,6 +58,14 @@ class HTMLElementImpl extends ElementImpl {
     }
   }
 
+  dispatchEvent(eventImpl) {
+    if (isDisabled(this)) {
+      return;
+    }
+
+    return super.dispatchEvent(eventImpl);
+  }
+
   click() {
     // https://html.spec.whatwg.org/multipage/interaction.html#dom-click
     // https://html.spec.whatwg.org/multipage/webappapis.html#fire-a-synthetic-mouse-event

diff --git a/test/web-platform-tests/to-upstream/html/editing/activation/click-bail-on-disabled.html b/test/web-platform-tests/to-upstream/html/editing/activation/click-bail-on-disabled.html
@@ -28,6 +28,16 @@
 
 }, "clicking a disabled button should not cause a click event");
 
+async_test(t => {
+
+  const element = document.querySelector("#el1");
+  element.addEventListener("click", t.unreached_func("click event should never happen"));
+
+  element.dispatchEvent(new MouseEvent('click'));
+  t.step_timeout(() => t.done(), 500);
+
+}, "dispatchEvent should not cause a click event");
+
 async_test(t => {
 
   const element = document.querySelector("#el2");