-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps, require node 8 #105
Conversation
Breaking changes also worth considering for a major release:
|
I think we should just get a major release out and evaluate dates and big ints for a later major. We haven't been doing many of these releases. Removing @brianc Thoughts on doing a major release for Node 8 and then doing a future major for Node 12 that incorporates BigInt + Date changes? |
Yeah I'm down with that. You want a major bump in node-posgres core as well right? I can sweep in a couple other breaking changes we wanted to make too. |
Yup, major bump here, and then a major bump in node-postgres updating the dep. |
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=========================================
+ Coverage 88.01% 88.62% +0.6%
=========================================
Files 5 4 -1
Lines 217 211 -6
=========================================
- Hits 191 187 -4
+ Misses 26 24 -2
Continue to review full report at Codecov.
|
d3937ab
to
0d2ea80
Compare
Finally took the time to merge this and release 3.0 to npm. Happy to take on further breaking changes in 4.0 which might be node 12+ assuming it comes early 2020. @brianc Do you need any help landing other changes to node-postgres? If not I can just open the PR bumping the pg-types dep and setting |
What is the correct way to parse the array now? This broke gajus/slonik#182 |
This is how I fixed it gajus/slonik@042669d, but not sure if that was the expected way. |
@gajus That works, yes. You can also write |
This would require a major version bump, which I think we should be doing anyway as numeric/binary oriented changes have been piling up in master. @brianc are you ok with going ahead with a major release of node-postgres as well? Node 4's EOL was about 1.5 years ago. 8's is coming up (December).
Closes #104