Skip to content

Commit

Permalink
Remove windows and macos from CI workflow as they are actually runnin…
Browse files Browse the repository at this point in the history
…g linux

Removes the windows and macos matrix from the CI workflow as they were never actually setting
the OS. Both were running against the "ubuntu-latest" OS. Trying to actually use them would
not work either as neither windows or macos is supported for service containers. A different
means will be needed to test on those platforms. Until that's done, this removes those from
the matrix as we were simply running the same thing 3x for the same node versions.
  • Loading branch information
sehrope committed Jan 5, 2024
1 parent 973a593 commit 47156c2
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
- run: yarn lint
build:
needs: lint
runs-on: ubuntu-latest
services:
postgres:
image: postgres:11
Expand All @@ -35,9 +34,17 @@ jobs:
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
strategy:
matrix:
node: ['10', '12', '14', '16', '18']
os: [ubuntu-latest, windows-latest, macos-latest]
node:
- '10'
- '12'
- '14'
- '16'
- '18'
- '20'
os:
- ubuntu-latest
name: Node.js ${{ matrix.node }} (${{ matrix.os }})
runs-on: ${{ matrix.os }}
env:
PGUSER: postgres
PGHOST: localhost
Expand All @@ -47,6 +54,9 @@ jobs:
SCRAM_TEST_PGUSER: scram_test
SCRAM_TEST_PGPASSWORD: test4scram
steps:
- name: Show OS
run: |
uname -a
- run: |
psql \
-c "SET password_encryption = 'scram-sha-256'" \
Expand Down

0 comments on commit 47156c2

Please sign in to comment.