Fix error handling test

#2569 introduced a bug in the test. The test never passed but because travis-ci lovingly broke the integration we had a long time ago the tests weren't run in CI until I merged. So, this fixes the tests & does a better job cleaning up the query in an errored state.
brianc · Aug 22, 2022 · 8bd43a5 · 8bd43a5
1 parent 747485d
commit 8bd43a5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/packages/pg-pool/index.js b/packages/pg-pool/index.js
@@ -417,11 +417,11 @@ class Pool extends EventEmitter {
           client.release(err)
           if (err) {
             return cb(err)
-          } else {
-            return cb(undefined, res)
           }
+          return cb(undefined, res)
         })
       } catch (err) {
+        client.release(err)
         return cb(err)
       }
     })

diff --git a/packages/pg-pool/test/error-handling.js b/packages/pg-pool/test/error-handling.js
@@ -38,14 +38,15 @@ describe('pool error handling', function () {
   })
 
   it('Catches errors in client.query', async function () {
-    await expect((new Pool()).query(null)).to.throwError()
-    await expect(async () => {
-      try {
-        await (new Pool()).query(null)
-      } catch (e) {
-        console.log(e)
-      }
-    }).not.to.throwError()
+    let caught = false
+    const pool = new Pool()
+    try {
+      await pool.query(null)
+    } catch (e) {
+      caught = true
+    }
+    pool.end()
+    expect(caught).to.be(true)
   })
 
   describe('calling release more than once', () => {