Skip to content

Commit

Permalink
Remove unreachable branch in parseE (#2020)
Browse files Browse the repository at this point in the history
The message is created with a fixed name.

56b7c41, released in pg 2.4.0, was when this became applicable and the type of a `notice` event’s argument changed to an Error.
  • Loading branch information
charmander authored and brianc committed Dec 12, 2019
1 parent b03a3bd commit c1f954b
Showing 1 changed file with 8 additions and 16 deletions.
24 changes: 8 additions & 16 deletions lib/connection.js
Expand Up @@ -594,27 +594,19 @@ Connection.prototype._readValue = function (buffer) {
// parses error
Connection.prototype.parseE = function (buffer, length) {
var fields = {}
var msg, item
var input = new Message('error', length)
var fieldType = this.readString(buffer, 1)
while (fieldType !== '\0') {
fields[fieldType] = this.parseCString(buffer)
fieldType = this.readString(buffer, 1)
}
if (input.name === 'error') {
// the msg is an Error instance
msg = new Error(fields.M)
for (item in input) {
// copy input properties to the error
if (Object.prototype.hasOwnProperty.call(input, item)) {
msg[item] = input[item]
}
}
} else {
// the msg is an object literal
msg = input
msg.message = fields.M
}

// the msg is an Error instance
var msg = new Error(fields.M)

// for compatibility with Message
msg.name = 'error'
msg.length = length

msg.severity = fields.S
msg.code = fields.C
msg.detail = fields.D
Expand Down

0 comments on commit c1f954b

Please sign in to comment.