Merge pull request #545 from CartoDB/master-do-not-assume-pgport

Do not assume PGPORT env variable is unset during testing
brianc · Mar 22, 2014 · f15a027 · f15a027
2 parents 128f9c0 + 7f43512
commit f15a027
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/test/unit/client/configuration-tests.js b/test/unit/client/configuration-tests.js
@@ -1,12 +1,16 @@
 require(__dirname+'/test-helper');
 
+var pguser = process.env['PGUSER'] || process.env.USER;
+var pgdatabase = process.env['PGDATABASE'] || process.env.USER;
+var pgport = process.env['PGPORT'] || 5432;
+
 test('client settings', function() {
 
   test('defaults', function() {
     var client = new Client();
-    assert.equal(client.user, process.env['PGUSER'] || process.env.USER);
-    assert.equal(client.database, process.env['PGDATABASE'] || process.env.USER);
-    assert.equal(client.port, 5432);
+    assert.equal(client.user, pguser);
+    assert.equal(client.database, pgdatabase);
+    assert.equal(client.port, pgport);
   });
 
   test('custom', function() {
@@ -69,7 +73,7 @@ test('calls connect correctly on connection', function() {
     usedHost = host;
   };
   client.connect();
-  assert.equal(usedPort, "/tmp/.s.PGSQL.5432");
+  assert.equal(usedPort, "/tmp/.s.PGSQL." + pgport);
   assert.strictEqual(usedHost, undefined)
 })