Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queued query errors #1503

Merged
merged 11 commits into from Oct 3, 2018
Merged

Queued query errors #1503

merged 11 commits into from Oct 3, 2018

Commits on Nov 20, 2017

  1. Add tests for query callbacks after connection-level errors

    @charmander
    charmander committed Nov 20, 2017
    Copy the full SHA
    7edfdf7 View commit details
    Browse the repository at this point in the history

  2. Ensure callbacks are executed for all queued queries after connection… 

    …-level errors

Separates socket errors from error messages, sends socket errors to all queries in the queue, marks clients as unusable after socket errors.

This is not very pleasant but should maintain backwards compatibility…?
    @charmander
    charmander committed Nov 20, 2017
    Copy the full SHA
    6cba93d View commit details
    Browse the repository at this point in the history

  3. Always call handleError asynchronously 

    This doesn’t match the original behaviour of the type errors, but it’s correct.
    @charmander
    charmander committed Nov 20, 2017
    Copy the full SHA
    7b6b7a1 View commit details
    Browse the repository at this point in the history

  4. Fix return value of Client.prototype.query in immediate error cases

    @charmander
    charmander committed Nov 20, 2017
    Copy the full SHA
    fdf5a4a View commit details
    Browse the repository at this point in the history

  5. Mark clients with closed connections as unusable consistently

    @charmander
    charmander committed Nov 20, 2017
    Copy the full SHA
    57bd144 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2017

  1. Add tests for error event when connecting Client

    @charmander
    charmander committed Dec 2, 2017
    Copy the full SHA
    a55da8a View commit details
    Browse the repository at this point in the history

Commits on May 4, 2018

  1. Merge branch 'master' into queued-query-errors

    @charmander
    charmander committed May 4, 2018
    Copy the full SHA
    70a2b56 View commit details
    Browse the repository at this point in the history

  2. Ensure the promise and callback versions of Client#connect always hav… 

    …e the same behaviour
    @charmander
    charmander committed May 4, 2018
    Copy the full SHA
    99ba060 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2018

  1. Give same error to queued queries as to active query when ending 

    and do so in the native Client as well.
    @charmander
    charmander committed May 5, 2018
    Copy the full SHA
    913a7e2 View commit details
    Browse the repository at this point in the history

  2. Restore original ordering between queued query callbacks and 'end' event

    @charmander
    charmander committed May 5, 2018
    Copy the full SHA
    dd127f2 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. Merge branch 'master' into queued-query-errors 

    Conflicts:
	test/integration/connection-pool/error-tests.js
    @charmander
    charmander committed Jul 13, 2018
    Copy the full SHA
    8ce5dee View commit details
    Browse the repository at this point in the history