Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom Promise dependency to be used on clients instead of the global Promise #1570

Closed

Conversation

pedrocarrico
Copy link

@pedrocarrico pedrocarrico commented Feb 9, 2018

Hi,

I was using connection pooling and passed in a bluebird Promise configuration and noticed that whenever I got a new Client from the pool it wouldn't get a bluebird Promise.

With these changes clients should pickup the Promise configuration from their pool as well as the option to specify any Promise dependency one might want.

Thanks,

@pedrocarrico pedrocarrico changed the title Allow custom Promise object to be used on clients instead of the global Promise Allow custom Promise dependency to be used on clients instead of the global Promise Feb 9, 2018
@charmander
Copy link
Collaborator

Covered with tests by #1518. I’ll reopen it after the bugfix it conflicts with (#1503) is in.

@charmander charmander closed this Feb 9, 2018
@pedrocarrico pedrocarrico deleted the client-promise-options branch March 1, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants