Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update pg-types to 2 #1806

Merged
merged 1 commit into from Jan 11, 2019
Merged

deps: update pg-types to 2 #1806

merged 1 commit into from Jan 11, 2019

Conversation

bendrucker
Copy link
Contributor

pg-types@2 drops node < 4 support but pg previously did so, so the upgrade isn't major for pg itself

See also: brianc/node-pg-types#76

drops node < 4 support but pg previously did so (not major)
@bendrucker
Copy link
Contributor Author

@brianc If you're interested, happy to take on some issue/PR grooming here as well. Up to you whether you'd like to include npm publish too.

@brianc
Copy link
Owner

brianc commented Jan 9, 2019

If you're interested, happy to take on some issue/PR grooming here as well. Up to you whether you'd like to include npm publish too.

I'd love that - I try to stay on top of things but its been only me and @charmander for years now & additional help would be welcome. ❤️

@brianc
Copy link
Owner

brianc commented Jan 9, 2019

Just to confirm - this is semver patch for this library once we merge this?

@bendrucker
Copy link
Contributor Author

this is semver patch for this library once we merge this

Yup! Because {"engines": {"node": ">= 4"}} was declared in an earlier release, it's not breaking to upgrade pg-types to a version that has the same version requirements (where it previously had none).

@brianc
Copy link
Owner

brianc commented Jan 11, 2019

sweet! merging now & releasing. Gonna release semver minor because this was added which is technically a new feature.

@brianc brianc merged commit 0e11b5c into brianc:master Jan 11, 2019
@bendrucker bendrucker deleted the pg-types-2 branch January 11, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants