Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove password from stringified outputs #2070

Merged
merged 4 commits into from Jan 13, 2020
Merged

Remove password from stringified outputs #2070

merged 4 commits into from Jan 13, 2020

Commits on Jan 13, 2020

  1. Keep ConnectionParameters’s password property writable 

    `Client` writes to it when `password` is a function.
    @charmander
    charmander committed Jan 13, 2020
    Copy the full SHA
    faa0f38 View commit details
    Browse the repository at this point in the history

  2. Avoid creating password property on pool options 

    when it didn’t exist previously.
    @charmander
    charmander committed Jan 13, 2020
    Copy the full SHA
    fa1d44a View commit details
    Browse the repository at this point in the history

  3. Allow password option to be non-enumerable 

    to avoid breaking uses like `new Pool(existingPool.options)`.
    @charmander
    charmander committed Jan 13, 2020
    Copy the full SHA
    410b89b View commit details
    Browse the repository at this point in the history

  4. Make password property definitions consistent 

    in formatting and configurability.
    @charmander
    charmander committed Jan 13, 2020
    Copy the full SHA
    6df7511 View commit details
    Browse the repository at this point in the history