Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support idle_in_transaction_session_timeout and statement_timeout for native driver #2323

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support idle_in_transaction_session_timeout and statement_timeout for native driver #2323

wants to merge 3 commits into from
+70 −1

Commits on Oct 24, 2020

  1. Support idle_in_transaction_session_timeout and statement_timeout for… 

    … native driver

Right now when using `pg` with `pg-native` the config options
`idle_in_transaction_session_timeout` and `statement_timeout`
do not get applied. This is due to, when building the connection
string for native driver these options aren't passed in.

I took advantage of `options` conn parameter and passed both the config options
into it using `-c` which postgres supports. This builds on top of the work happened in <TBD LINK>.

Also added some tests. Very much open to feedback and comments :).
    Shayon Mukherjee committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    52f67d3 View commit details
    Browse the repository at this point in the history

  2. Skip adding options twice and extend specs

    Shayon Mukherjee committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    e3f89ce View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2020

  1. Lint fix

    Shayon Mukherjee committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    2f5e812 View commit details
    Browse the repository at this point in the history