Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more SASL validation and fix tests #2436

Merged
merged 11 commits into from Dec 30, 2020
Merged

Add more SASL validation and fix tests #2436

merged 11 commits into from Dec 30, 2020

Commits on Dec 29, 2020

  1. Add sha256 SASL helper

    @sehrope
    sehrope committed Dec 29, 2020
    Copy the full SHA
    54c0cc8 View commit details
    Browse the repository at this point in the history

  2. Rename internal createHMAC(...) to hmacSha256(...)

    @sehrope
    sehrope committed Dec 29, 2020
    Copy the full SHA
    53081a3 View commit details
    Browse the repository at this point in the history

  3. Add parseAttributePairs(...) helper for SASL

    @sehrope
    sehrope committed Dec 29, 2020
    Copy the full SHA
    d5abacc View commit details
    Browse the repository at this point in the history

  4. Tighten arg checks in SASL xorBuffers(...)

    @sehrope
    sehrope committed Dec 29, 2020
    Copy the full SHA
    a1a923b View commit details
    Browse the repository at this point in the history

  5. Add SASL nonce check for printable chars

    @sehrope
    sehrope committed Dec 29, 2020
    Copy the full SHA
    d8ac49f View commit details
    Browse the repository at this point in the history

  6. Add SASL server salt and server signature base64 validation

    @sehrope
    sehrope committed Dec 29, 2020
    Copy the full SHA
    697befc View commit details
    Browse the repository at this point in the history

  7. Add check for non-empty SASL server nonce

    @sehrope
    sehrope committed Dec 29, 2020
    Copy the full SHA
    c615fa0 View commit details
    Browse the repository at this point in the history

  8. Rename SASL helper to parseServerFirstMessage(...)

    @sehrope
    sehrope committed Dec 29, 2020
    Copy the full SHA
    1c3f547 View commit details
    Browse the repository at this point in the history

  9. Add parameter validation to SASL continueSession(...)

    @sehrope
    sehrope committed Dec 29, 2020
    Copy the full SHA
    dd1d583 View commit details
    Browse the repository at this point in the history

  10. Split out SASL final message parsing into parseServerFinalMessage(...)

    @sehrope
    sehrope committed Dec 29, 2020
    Copy the full SHA
    0a5498b View commit details
    Browse the repository at this point in the history

  11. Fix SCRAM tests 

    Removes custom assert.throws(...) so that the real one from the assert package is used and
fixes the SCRAM tests to reflect the updated error messages and actual checking of errors.

Previously the custom assert.throws(...) was ignoring the error signature validation.
    @sehrope
    sehrope committed Dec 29, 2020
    Copy the full SHA
    736173f View commit details
    Browse the repository at this point in the history