Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for using promises in Cursor methods #2554

Merged
merged 4 commits into from Jul 27, 2021
Merged

Add support for using promises in Cursor methods #2554

merged 4 commits into from Jul 27, 2021

Commits on Jun 22, 2021

  1. Add similar promise variables to read() and close() as seen in query()

    @Bluenix2
    Bluenix2 committed Jun 22, 2021
    Copy the full SHA
    fbb3bfc View commit details
    Browse the repository at this point in the history

  2. Add testing for promise specific usage

    @Bluenix2
    Bluenix2 committed Jun 22, 2021
    Copy the full SHA
    21e36b1 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Simplify tests as no real callbacks are involved 

    Removes usage of `done()` since we can end the test when we exit the function

Co-Authored-By: Charmander <~@charmander.me>
    @Bluenix2 @charmander
    Bluenix2 and charmander committed Jun 23, 2021
    Copy the full SHA
    b2e3b77 View commit details
    Browse the repository at this point in the history

  2. Switch to let over var

    @Bluenix2
    Bluenix2 committed Jun 23, 2021
    Copy the full SHA
    631bfcc View commit details
    Browse the repository at this point in the history