Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immediately unref() maxLifetimeSeconds Timeout object to prevent blocking allowExitOnIdle #2721

Merged
merged 1 commit into from May 13, 2022
Merged

Immediately unref() maxLifetimeSeconds Timeout object to prevent blocking allowExitOnIdle #2721

merged 1 commit into from May 13, 2022

Conversation

ChrisWritable
Copy link
Contributor

@brianc
Copy link
Owner

brianc commented May 11, 2022

Hey sorry for the headache here but CI was broken. I fixed it yesterday...would you be able to rebase onto master? Then the tests should pass and we can merge this up and get a release out! Thank you so much for contributing! ❤️

@ChrisWritable
Copy link
Contributor Author

ChrisWritable commented May 12, 2022 via email

@brianc
Copy link
Owner

brianc commented May 12, 2022 •
edited

awesome! Thanks @ChrisWritable - I'll get this released in a few days at most...just waiting on a few other PRs to rebsase their changes so I can bundle up stuff for a new version. Thanks for your contribution. 😄

@brianc brianc merged commit 3ca5602 into brianc:master May 13, 2022
@shleeable shleeable mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charmander charmander charmander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrisWritable @brianc @charmander