Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting ssl.servername #2804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow setting ssl.servername #2804

wants to merge 1 commit into from

Conversation

gabegorelick
Copy link
Contributor

Fixes #2803

@brianc
Copy link
Owner

brianc commented Sep 3, 2022

Thanks for this! Is it possible to write a test for this? Without a test it becomes pretty hard to maintain the code for me over long periods of time.

@gabegorelick
Copy link
Contributor Author

Is it possible to write a test for this?

I'm happy to if someone points me to a good existing test to copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ssl option servername is ignored
2 participants
@gabegorelick @brianc