Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape \0 in identifiers and literals #2900

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Escape \0 in identifiers and literals #2900

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12fca43
Escape \0 in identifiers and literals
benjie Jan 19, 2023
3ceb90b
Bump
benjie Mar 11, 2023
2bb87d0
Throw error on \0
benjie Mar 13, 2023
90309cd
Apply suggestions from code review
benjie Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/pg/lib/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,9 @@ class Client extends EventEmitter {

// Ported from PostgreSQL 9.2.4 source code in src/interfaces/libpq/fe-exec.c
escapeIdentifier(str) {
if (str.includes('\0')) {
throw new Error('Identifier contains \\0, which is not allowed in PostgreSQL identifiers')
}
return '"' + str.replace(/"/g, '""') + '"'
}

Expand All @@ -459,6 +462,8 @@ class Client extends EventEmitter {
} else if (c === '\\') {
escaped += c + c
hasBackslash = true
} else if (c === '\0') {
throw new Error('Literal contains \\0, which is not allowed in PostgreSQL strings')
} else {
escaped += c
}
Expand Down