Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: conflict between browser URL object and Node URL object" #3188

Merged
merged 1 commit into from Apr 2, 2024

Conversation

brianc
Copy link
Owner

@brianc brianc commented Apr 2, 2024

Reverts #3061

This addresses a backwards incompatible regression described by #3187

Copy link

Deploying node-postgres with  Cloudflare Pages  Cloudflare Pages

Latest commit: d8ee8c4
Status: ✅  Deploy successful!
Preview URL: https://594e2436.node-postgres.pages.dev
Branch Preview URL: https://revert-3061-fix-url-object-c.node-postgres.pages.dev

View logs

@brianc brianc merged commit 95655fe into master Apr 2, 2024
15 checks passed
@brianc
Copy link
Owner Author

brianc commented Apr 2, 2024

For future reference if you run into an incompatibility of the URL module due to old polyfills or other environments, its recommended to use the config object based connection instead of a connection string to avoid the issue.

@brianc brianc deleted the revert-3061-fix/url-object-conflict branch April 2, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant