Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added per-client type parser overrides. #679

Merged
merged 4 commits into from Dec 4, 2014
Merged

Conversation

whitelynx
Copy link
Contributor

Adds Client#getTypeParser() and Client#setTypeParser().

Fixes #676.

@brianc
Copy link
Owner

brianc commented Nov 17, 2014

Interesting - I like this approach. I was also thinking of allowing a custom instance of pg-types to be passed into the client...but this also works.

@brianc
Copy link
Owner

brianc commented Dec 2, 2014

Hey @whitelynx sorry there's a merge conflict now - if you feel good about fixing the merge conflict I'd love to get this merged into master & pushed out to npm! The idea is really good.

@whitelynx
Copy link
Contributor Author

I updated this, and refactored it a bit to simplify things.

@brianc
Copy link
Owner

brianc commented Dec 3, 2014

awesome!!! will check this out later tonight. 😄

On Wed, Dec 3, 2014 at 6:08 PM, David Bronke notifications@github.com
wrote:

I updated this, and refactored it a bit to simplify things.


Reply to this email directly or view it on GitHub
#679 (comment).

@brianc
Copy link
Owner

brianc commented Dec 4, 2014

@whitelynx Sorry I didn't get to this last night.

This is excellent. 💃 I'm gonna merge this & push a new minor version to npm right now. Super appreciate the pull request, updating it to the new version, tests, and your patience!! 😄

brianc added a commit that referenced this pull request Dec 4, 2014
Added per-client type parser overrides.
@brianc brianc merged commit d3b47a9 into brianc:master Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-connection type parser overrides
2 participants