Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix slovak translations #2872

Merged
merged 3 commits into from Oct 20, 2023

Conversation

s4muel
Copy link
Contributor

@s4muel s4muel commented Oct 19, 2023

a found out inconsistencies and missing translations in slovak language. so here is a fix

Comment on lines 49 to 55
'/(\b|$)hodina(\b|$)/' => 'hodinou',
'/(\b|$)minúta(\b|$)/' => 'minútou',
'/(\b|$)sekunda(\b|$)/' => 'sekundou',
'/(\b|$)deň(\b|$)/' => 'dňom',
'/(\b|$)týždeň(\b|$)/' => 'týždňom',
'/(\b|$)mesiac(\b|$)/' => 'mesiacom',
'/(\b|$)rok(\b|$)/' => 'rokom',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'/(\b|$)hodina(\b|$)/' => 'hodinou',
'/(\b|$)minúta(\b|$)/' => 'minútou',
'/(\b|$)sekunda(\b|$)/' => 'sekundou',
'/(\b|$)deň(\b|$)/' => 'dňom',
'/(\b|$)týždeň(\b|$)/' => 'týždňom',
'/(\b|$)mesiac(\b|$)/' => 'mesiacom',
'/(\b|$)rok(\b|$)/' => 'rokom',
'/\bhodina\b/' => 'hodinou',
'/\bminúta\b/' => 'minútou',
'/\bsekunda\b/' => 'sekundou',
'/\bdeň\b/' => 'dňom',
'/\btýždeň\b/' => 'týždňom',
'/\bmesiac\b/' => 'mesiacom',
'/\brok\b/' => 'rokom',

\b includes $ and $ cannot be at the beginning

@kylekatarnls
Copy link
Collaborator

RegExp can be slightly optimized as per the above, but really a great update. ❤️

and update SkTest to align with SkSktest
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
@kylekatarnls kylekatarnls added the translation Rely to internationalization label Oct 20, 2023
@kylekatarnls kylekatarnls added this to the 2.72.0 milestone Oct 20, 2023
@kylekatarnls kylekatarnls merged commit b02302e into briannesbitt:master Oct 20, 2023
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Rely to internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants