Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to collect the DNS names from a certificate (finish work from #91 ) #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Geal
Copy link

@Geal Geal commented Jul 4, 2019

it's time we get this done :)

In this PR:

  • rebase on current master
  • change the untrusted dependency to the alpha crate like ring does
  • fix various warnings (linters that prevented compilation)
  • add WildcardDNSName, WildcardDNSNameRef, and the GeneralDNSNameRef enum
  • remove the old test certificate with the c*.netflix.com name, to a certificate with *.netflix.com, since the name validation function is a bit more strict

cc @seanmonstar

@Geal
Copy link
Author

Geal commented Jul 5, 2019

the travis build failed with error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256' to '/Users/travis/.rustup/tmp/dvf9zas_bt4ybmn2_file' @briansmith could you restart the failed build job?

@Geal
Copy link
Author

Geal commented Jul 15, 2019

(rebased on master)

@Geal
Copy link
Author

Geal commented Aug 21, 2019

rebased again, all tests pass. @briansmith any ideas if this could be merged?

@seanmonstar
Copy link

@briansmith you mentioned at RustConf that we might be able to merge this? WDYT?

@Keruspe
Copy link

Keruspe commented Sep 12, 2019

@briansmith any news on this?

@Geal
Copy link
Author

Geal commented Oct 10, 2019

ping @briansmith ?

@Geal
Copy link
Author

Geal commented Feb 17, 2020

@briansmith is there anything blocking this?

@Ten0
Copy link

Ten0 commented Jul 16, 2020

@briansmith up

@Geal
Copy link
Author

Geal commented Nov 22, 2020

@briansmith is there anything blocking this PR from being merged? I could rebase it over #125 if needed.
If it should not ever go into webpki (it's been 3 years already...), a clear "no" would be fine too

Base automatically changed from master to main January 14, 2021 01:31
@briansmith
Copy link
Owner

Note: I renamed the "master" branch to "main". Sorry for the inconvenience. This PR has had its base branch updated to "main" but you'll need to deal with the change in your local repo yourself.

@Geal
Copy link
Author

Geal commented Jan 14, 2021

@briansmith it's rebased over main, let me know if you need any changes

@Geal Geal force-pushed the cert-dns-names branch 2 times, most recently from 6901f07 to 2534131 Compare January 14, 2021 13:20
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #103 (f04436e) into main (9cf9f45) will increase coverage by 2.89%.
The diff coverage is 83.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   73.56%   76.45%   +2.89%     
==========================================
  Files          14       14              
  Lines        1362     1525     +163     
==========================================
+ Hits         1002     1166     +164     
+ Misses        360      359       -1     
Impacted Files Coverage Δ
src/name/dns_name.rs 60.37% <43.47%> (-1.02%) ⬇️
tests/integration.rs 99.24% <98.91%> (-0.76%) ⬇️
src/name/verify.rs 27.22% <100.00%> (+23.08%) ⬆️
src/webpki.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf9f45...f04436e. Read the comment docs.

@Geal
Copy link
Author

Geal commented Jan 20, 2021

@briansmith all CI checks pass, it should be good to go now

@Chaostheorie
Copy link

Any chance of this getting merged?

@Ten0
Copy link

Ten0 commented Apr 3, 2023

Since this repository is not maintained anymore, the main one seems to now be the fork at https://github.com/rustls/webpki.

In case you want to follow (or upvote it 🙄), this PR has been ported over to: rustls/webpki#6

(as far as I'm concerned I'm still blocked on it since 2020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants