Optional serde support for DnsName/DnsNameRef #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @briansmith as I'm going through old PRs: assuming I resolve the merge conflict, would you still be interested in merging this, or should I assume that inaction here means it's not desired? I don't mind either way, just want to check since this PR is 3 years old and I wouldn't mind rebasing it if you do think it's useful. |
|
I don't think adding Serde support makes sense for this project. I think there are ways of doing this without webpki having to provide the functionality itself. Sorry about the radio silence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would add implement
Serialize/DisplayforDnsNameRefbut I figured there was a good reason to not store it as&str, and didn't want to bother with refactoring that without talking to anyone.This adds serde support for both types under an optional feature. It also implements
DisplayforDnsNamesince I figured it'd be reasonable to have.