Add support for verifying certificate chain with EKU #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@briansmith, would you please review this patch to see if there is any comment? |
|
It looks like this pull request has been open for quite a while. It looks like it is in need of review. What is the status of the review and any remaining approval process work? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a use case(spdm) where Certificate Extended Key Usage(EKU) Oid is customized, and EndCertEntity is used to verify certificate chain with customized EKU. But the current EndCertEntity does not expose the verify function with eku. So I made a patch to expose a function called
verify_is_valid_cert_with_ekufor EndCertEntity.What do you think of this?
Any chance we can see add this API in webpki?