Fix issue on PHP 7.2 & 7.3

brick · Apr 20, 2021 · bb3177c · bb3177c
1 parent 5ebcd63
commit bb3177c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/Engine/PDOEngine.php b/src/Engine/PDOEngine.php
@@ -90,7 +90,11 @@ protected function executeQuery(string $query, array $parameters) : array
 
         $this->pdo->setAttribute(\PDO::ATTR_ERRMODE, $errMode);
 
-        assert($result !== false);
+        if ($result === false) {
+            // not sure why, but on PHP 7.2 & 7.3, running a query for a non-supported operation
+            // yields no exception, no error (SQLSTATE 00000), but returns false; works fine in PHP 7.4+
+            throw GeometryEngineException::operationNotSupportedByEngine();
+        }
 
         return $result;
     }

diff --git a/src/Exception/GeometryEngineException.php b/src/Exception/GeometryEngineException.php
@@ -32,11 +32,11 @@ public static function unimplementedMethod(string $methodName) : GeometryEngineE
     }
 
     /**
-     * @param \Exception $e
+     * @param \Exception|null $e
      *
      * @return GeometryEngineException
      */
-    public static function operationNotSupportedByEngine(\Exception $e) : GeometryEngineException
+    public static function operationNotSupportedByEngine(?\Exception $e = null) : GeometryEngineException
     {
         return new self('This operation is not supported by the geometry engine.', 0, $e);
     }