Currency should be JSON serializable
#79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense! Please add a test and I'll merge it 👍 |
|
@BenMorel added a test - let me know if you had others in mind. (Existing |
|
Thank you, released as 0.8.1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We regularly pass the currency along to an API as part of an array and expected
Currencyto serialize to a JSON string because it's stringable. However, it serializes to an empty array.v0.7.0 made
AbstractMoneyJSON serializable, butCurrencywasn't treated that way.This updates
Currencyto be JSON serializable when using it separately fromMoney.