Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

chore(ci): pin gh-pages to known working version #79

Merged
merged 1 commit into from Jul 13, 2020

Conversation

vdice
Copy link
Contributor

@vdice vdice commented Jul 10, 2020

The most recent chart release initially failed, seemingly due to tschaub/gh-pages#354:

 $ k logs brigadecore-charts-publish-01ecx5q72k8j4wj3gcqkxb5834
/usr/local/bin/gh-pages -> /usr/local/lib/node_modules/gh-pages/bin/gh-pages.js
/usr/local/bin/gh-pages-clean -> /usr/local/lib/node_modules/gh-pages/bin/gh-pages-clean.js
+ gh-pages@3.1.0
added 52 packages from 14 contributors in 3.351s
The "path" argument must be of type string. Received undefined

Rerunning the job with this utility pinned to 3.0.0 worked:

 $ k logs brigadecore-charts-publish-01ecx77xnamn9yzr8sndjh1g35
/usr/local/bin/gh-pages -> /usr/local/lib/node_modules/gh-pages/bin/gh-pages.js
/usr/local/bin/gh-pages-clean -> /usr/local/lib/node_modules/gh-pages/bin/gh-pages-clean.js
+ gh-pages@3.0.0
added 41 packages from 14 contributors in 2.205s
Published

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
@@ -51,7 +51,7 @@ function publish(e, project) {
publisher.storage.enabled = true;

publisher.tasks = [
"npm install -g gh-pages",
"npm install -g gh-pages@3.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho, this is better anyway because it's more deterministic.

Copy link
Contributor

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdice vdice merged commit 563d7ab into brigadecore:master Jul 13, 2020
@vdice vdice deleted the chore/pin-gh-pages branch July 13, 2020 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants