upgrade electron 7.1.8 -> 7.1.9 #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mason Fish <mason@looky.cloud>
jameskerr
reviewed
Mar 2, 2020
jameskerr
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that the height of the draggable element which I increased in #431 was only one of two culprits to the no-drag problem. This issue ALSO occurs if you resize the height of the app and then try to drag it again (which fails). Turns out this is an issue that exists in electron and was at least partially fixed in the next patch version up from where we are currently at as noted in electron/electron#21723. From my own testing, this does seem to fix the issue for us as well.
Signed-off-by: Mason Fish mason@looky.cloud