-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inferred sex tables to stats page #1416
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny cleanup and a general comment, good to go otherwise.
browser/src/StatsPage/StatsPageTables/InferredSexPerGeneticAncestryTables.tsx
Outdated
Show resolved
Hide resolved
browser/src/StatsPage/StatsPageTables/InferredSexPerGeneticAncestryTables.tsx
Outdated
Show resolved
Hide resolved
thank you so much for working on this! I have a few comments:
One additional comment: since this update impacts the stats page, I think it'd be a good idea to post screenshots in #gnomad_browser to get feedback. |
5f5de61
to
f431932
Compare
eaa1fa4
to
e611668
Compare
Commenting checklist for myself:
|
a427c7d
to
35b397e
Compare
0835d91
to
1e9d7cd
Compare
Resolves #1355
Adds 2 tables to the stats page that display the number of inferred sex sample per genetic ancestry group in v4