-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JN-1078] trigger survey assign #889
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, but I do wonder if this should only be on survey completion. I found it confusing as a user experience because I signed in as Jsalk, who had already completed the survey, and I changed the answer and it didn't give me the new one.
I could see the argument that, if I select that answer but don't complete the survey, I shouldn't get the new survey. But I do think if you change an answer on a completed survey it should assign you the new survey, I wouldn't expect to have to re-complete it. Otherwise it worked great!
As an aside, I also noticed that the eligibility rule was in the DB, but it didn't show up in the lost interests UI. A cursory look didn't make the bug seem obvious but I'll take a peek and see if I can figure out why it's doing that. I have a pr up to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(i'll go ahead and approve, up to you if you wanna fix the edge case, I don't know how common it would be)
Connor and I chatted some more -- we'll leave as-is for now, and then open this up for discussion at next demo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
Previously, we would only assign survey tasks on enrollee creation or on publication of a survey. This makes it so survey completion events can trigger follow-up surveys.
NOTE: in testing this I discovered that we're not storing answerType for any answers. I've added a temporary workaround here, and created a ticket for the full fix
TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)
https://sandbox.demo.localhost:3001/
as jsalk@test.com