[JN-1083] Temp fix for empty search expression #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devonbush
approved these changes
May 16, 2024
| @@ -56,6 +56,13 @@ const SurveyEditorView = (props: SurveyEditorViewProps) => { | |||
| const [draft, setDraft] = useState<FormDraft | undefined>( | |||
| !readOnly ? getDraft({ formDraftKey: FORM_DRAFT_KEY }) : undefined) | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
🤦 I keep doing this lol. I blame the coffee making me jittery.
|
MatthewBemis
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
If you go to edit a survey with an eligibility rule, it shows as empty. If you then save, it strips the eligibility rule (yikes). This is only if you have the fancy query builder. This is because on the first render, the query builder has nothing, so it does an
onChangecall to make it empty.Without doing fancy ref stuff, I figured just making it skip changing the eligibility rule if the string is empty is fine in the meantime, since once we have antlr it will work properly & this is only shown to prototype users/superusers anyway, so a wonky UX is fine in the meantime.
TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)