Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JN-1086] sanitizing question stableIds #895

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

devonbush
Copy link
Collaborator

DESCRIPTION (include screenshots, and mobile screenshots for participant UX)

General hardening with respect to question stableIds. this prevents entering and saving stableIds with whitespace. this also hardens the export to sanitize the headers to handle special characters there. This was prompted by HeartHive realizing that their import had resulted in some questions with stableIds that had trailing whitespace.

TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)

  1. redeploy apiAdminApp
  2. go to https://localhost:3000/ourhealth/studies/ourheart/env/sandbox/forms/surveys/oh_oh_mental?selectedElementPath=pages%5B0%5D.elements%5B2%5D
  3. hit "Add next question"
  4. attempt to type whitespace or other special chars into the editor

Copy link

sonarcloud bot commented May 17, 2024

@devonbush devonbush added this pull request to the merge queue May 20, 2024
Merged via the queue into development with commit 0f9ab0a May 20, 2024
12 checks passed
@devonbush devonbush deleted the db-sanitize-stableIds branch May 20, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants