[JN-1087] Allow proxies to join the study after the fact #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
devonbush
approved these changes
May 19, 2024
| private Enrollee findOrCreateEnrolleeForEnrollment(ParticipantUser user, PortalParticipantUser ppUser, StudyEnvironment studyEnv, String studyShortcode, UUID preEnrollResponseId, boolean isSubjectEnrollment) { | ||
| return enrolleeService | ||
| .findByParticipantUserIdAndStudyEnv(user.getId(), studyShortcode, studyEnv.getEnvironmentName()) | ||
| .filter(e -> { |
There was a problem hiding this comment.
let's find a better name for this variable than "e" since that usual is used for "error". any reason this can't be 'enrollee'?
| Enrollee proxyAfterSubjectEnroll = enrolleeService.find(proxy.getId()).orElseThrow(); | ||
| assertThat(proxyAfterSubjectEnroll.isSubject(), equalTo(true)); | ||
| assertThat(proxyAfterSubjectEnroll.getPreEnrollmentResponseId(), equalTo(savedResponse.getId())); | ||
| } |
There was a problem hiding this comment.
nice, seems like we could use a couple of tests (or addenda to tests above) confirming that an enrollee can't enroll twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
Viewing your hub page as a proxy:
Pre-fills proxy and name questions when you click:
Mobile
Also, disables hub page messages if you are not a subject.
TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)