[fix] running lint as a seperate CI task and fixes all errors to ensure CI passes #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Apr 20, 2020
…ypes as they are failing now
|
@rwjblue I found a bug in lib/cli.js it looks like we were passing a string but it was expecting an error instance. Which would silently fail and cause the ui to write undefined. |
stefanpenner
approved these changes
Apr 21, 2020
|
bump on merging this as it fixes an error with ui.writeError as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #437
Motivation
To ensure that linting is run. The previous linting setup was not catching all issues before they were submitted.
I had to turn off
no-unused-varsbecause it does not currently work with imported types. The issue here typescript-eslint/typescript-eslint#1856.