Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] general cleanup fixes in lib/program-helper.js #9

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

brodybits
Copy link
Owner

  • remove shebang line
  • keep all require statements as const statements, in the beginning of the module
  • use const instead of var
  • minor spacing improvements
  • fix module exports to export named functions
  • use correct name for the commander program object in the getOptions function

- remove shebang line
- keep all require statements as const statements,
  in the beginning of the module
- use const instead of var
- minor spacing improvements
- fix module exports to export named functions
- use correct name for the commander program object
  in the `getOptions` function
@brodybits brodybits self-assigned this Nov 1, 2019
Christopher J. Brody added 4 commits November 2, 2019 22:00
- factor out intermediate `args` declaratoin
- use smarter chaining to remove an extra `join` call
- add semicolon for the sake of consistency
@brodybits brodybits changed the title general cleanup fixes in lib/program-helper.js [WIP] general cleanup fixes in lib/program-helper.js Nov 3, 2019
@brodybits
Copy link
Owner Author

Some other PRs such as #14 & #16 will likely invalidate some of these changes. I am planning to rebase this PR once we finish review & merge of #14 & #16.

/cc @rbiggs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant