Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientHints: remove javascript support #2521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uazo
Copy link
Collaborator

@uazo uazo commented Dec 29, 2022

Description

I don't know what you want to do yet, but this is the patch that removes support from javascript as #973 (comment)

All submissions

  • there are no other open Pull Requests for the same update/change
  • Bromite can be built with these changes
  • I have tested that the new change works as intended (AVD or physical device will do)

Format

  • patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
  • patch description contains explanation of changes
  • no unnecessary whitespace or unrelated changes

@PF4Public
Copy link

PF4Public commented Jan 27, 2023

@csagan5 Do you plan merging this PR?

PS: I've applied this patch over ungoogled-chromium locally and all client hints seem to be gone, including the JS hints.

PPS: https://browserleaks.com/client-hints does not detect anything, but https://coveryourtracks.eff.org/ does correctly detect screen size, platform, hardware concurrency and device memory.

@uazo
Copy link
Collaborator Author

uazo commented Jan 29, 2023

does correctly detect screen size, platform, hardware concurrency and device memory.

this patch does not change the behaviour of the standard javascript api, by the way, the other patches do not change that information in any way either.
if you are interested in camouflaging (and testing :) screen size, try #2294

for the desktop version you need:
https://github.com/uazo/bromite/blob/next-v109/build/patches/Content-settings-infrastructure.patch
https://github.com/uazo/bromite/blob/next-v109/build/patches/00Content-settings-infrastructure--win-fixup-.patch
https://github.com/uazo/bromite/blob/next-v109/build/patches/00Viewport-Protection-flag.patch
https://github.com/uazo/bromite/blob/next-v109/build/patches/00Viewport-Protection-Site-Setting.patch

build for windows works without problems, I would like to understand if anything else is needed for linux

platform, hardware concurrency and device memory.

"platform" what do you mean? for the others we have nothing yet

@PF4Public
Copy link

PF4Public commented Jan 29, 2023

this patch does not change the behaviour of the standard javascript api, by the way, the other patches do not change that information in any way either.

I realize that, just wanted to mention, in case you wanted feedback and/or improve this patch further

"platform" what do you mean?

It correctly identifies, that I'm on "Linux x86_64"
EDIT: never mind, it could be easily extracted from user agent, duh :)

if you are interested in camouflaging (and testing :) screen size, try #2294
[…]
I would like to understand if anything else is needed for linux

Thanks for pointing me there! I'll give it a try later and let you know how it works on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants