Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant patch hunk #2548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chirayudesai
Copy link

  • One patch removes it, the other adds it

Description

Please explain here what feature or bugfix these changes are addressing and why they should be included

All submissions

  • there are no other open Pull Requests for the same update/change
  • Bromite can be built with these changes
  • I have tested that the new change works as intended (AVD or physical device will do)

Format

  • patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
  • patch description contains explanation of changes
  • no unnecessary whitespace or unrelated changes

@uazo
Copy link
Collaborator

uazo commented Jan 12, 2023

pure curiosity: how did you notice this? do you have something automatic to propose? i am always looking for improvements in that area.

* One patch removes it, the other adds it back
@chirayudesai
Copy link
Author

I wish I had a better answer, but in this our fork only has 1 of these patches so the other one conflicted, and I tried to see why that was.

@csagan5
Copy link
Contributor

csagan5 commented Jan 27, 2023

Perhaps the code should be kept and not removed by the binary blobs patch?

@uazo
Copy link
Collaborator

uazo commented Jan 28, 2023

Perhaps the code should be kept and not removed by the binary blobs patch?

correct.
That code alerts the ui that the download phase of the language files is finished. In bromite, the download is not done, since bromite already has all the files in the apk, but, by not communicating anything to the ui, it hangs and does not allow language selection.
I remember putting it back in Override-Navigator-Language.patch, but I honestly don't remember why I didn't take it out of Remove-binary-blob-integrations.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants