Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches for v109 #2561

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Patches for v109 #2561

wants to merge 1 commit into from

Conversation

csagan5
Copy link
Contributor

@csagan5 csagan5 commented Jan 27, 2023

Description

Patches for v109.

All submissions

  • there are no other open Pull Requests for the same update/change
  • Bromite can be built with these changes
  • I have tested that the new change works as intended (AVD or physical device will do)

Format

  • patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
  • patch description contains explanation of changes
  • no unnecessary whitespace or unrelated changes

Build fixes

Use helper macros to define base::Features
@uazo
Copy link
Collaborator

uazo commented Feb 2, 2023

there is a crash in the always incognito patch, if you close a group of tabs.
I fixed it with this https://github.com/uazo/bromite/blob/next-v109/build/patches/00109-Add-an-always-incognito-mode-fixup.patch
tell me whether to pass you the whole patch with a pull

@uazo
Copy link
Collaborator

uazo commented Feb 2, 2023

in addition, a new flag OPAQUE_ORIGIN_FOR_INCOMING_INTENTS was added in v109, which is active by default but which, as we developed the "Enable share intent" and "force open external links in incognito flag" in "Add custom tab intents privacy option" patches, we do not take into account.

https://github.com/uazo/bromite/blob/next-v109/build/patches/00fix-InitiatorOrigin--add-fixup-.patch the fix, but the code must be separated in the two patches respectively

@uazo
Copy link
Collaborator

uazo commented Feb 2, 2023

in 109 I found

there are also others that I think should be verified, see https://github.com/uazo/bromite-flags-list/blob/main/flags-to-check#L520

@csagan5
Copy link
Contributor Author

csagan5 commented May 22, 2023

@uazo I will pick up from this and release it; then I will check whether to skip some versions or not.

@uazo
Copy link
Collaborator

uazo commented May 23, 2023

I am happy to hear from you again.

I will check whether to skip some versions or not.

if you want to talk about it, I would be happy to

@Abyssgrowth
Copy link

Hello there, may i ask about the status / future of bromite, it seems so the project is dead now.
Are there people releasing forks of bromite for the latest version with all security patches? Where can we find anything?

@Spark4000
Copy link

https://github.com/uazo/bromite-buildtools

@Abyssgrowth
Copy link

https://github.com/uazo/bromite-buildtools

Oh it was right there, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants