Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: broofa/mime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.4.1
Choose a base ref
...
head repository: broofa/mime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.4.2
Choose a head ref
  • 4 commits
  • 4 files changed
  • 2 contributors

Commits on Apr 3, 2019

  1. chore: Update platforms tested in travis

    @broofa
    broofa committed Apr 3, 2019
    Copy the full SHA
    bd2795a View commit details

Commits on Apr 5, 2019

  1. fix: don't use arrow function introduced in 2.4.1 

    There is ES6 syntax introduced in the latest release 2.4.1. Meanwhile the whole package is written in ES5 (`var` instead of `const`, etc).

Introducing this tiny use of arrow function renders usage of this module in browsers like IE11 impossible.

I hope it's not a big deal to stick with older syntax to remain consistent with code style and browser/node support
    @vladgolubev
    vladgolubev authored Apr 5, 2019
    Copy the full SHA
    2e00b5c View commit details

Commits on Apr 7, 2019

  1. Merge pull request #225 from vladgolubev/patch-1 

    Don't use arrow function introduced in 2.4.1
    @broofa
    broofa authored Apr 7, 2019
    Copy the full SHA
    4d59d76 View commit details

  2. chore(release): 2.4.2

    @broofa
    broofa committed Apr 7, 2019
    Copy the full SHA
    30ba26d View commit details
Showing with 12 additions and 3 deletions.
  1. +1 −1 .travis.yml
  2. +9 −0 CHANGELOG.md
  3. +1 −1 Mime.js
  4. +1 −1 package.json
2 changes: 1 addition & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
language: node_js
node_js:
- "4"
- "6"
- "8"
- "10"
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -2,6 +2,15 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## [2.4.2](https://github.com/broofa/node-mime/compare/v2.4.1...v2.4.2) (2019-04-07)


### Bug Fixes

* don't use arrow function introduced in 2.4.1 ([2e00b5c](https://github.com/broofa/node-mime/commit/2e00b5c))



## [2.4.1](https://github.com/broofa/node-mime/compare/v2.4.0...v2.4.1) (2019-04-03)


2 changes: 1 addition & 1 deletion Mime.js
View file
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@ function Mime() {
*/
Mime.prototype.define = function(typeMap, force) {
for (var type in typeMap) {
var extensions = typeMap[type].map(t => t.toLowerCase());
var extensions = typeMap[type].map(function(t) {return t.toLowerCase()});
type = type.toLowerCase();

for (var i = 0; i < extensions.length; i++) {
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -41,5 +41,5 @@
"url": "https://github.com/broofa/node-mime",
"type": "git"
},
"version": "2.4.1"
"version": "2.4.2"
}