Ace editor theme to be selectable #1839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawamataryo
force-pushed
the
fix-936
branch
from
4c269b6
to
8487d89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for awesome extension.
I often use editor mode, but it was a hassle to specify the theme of the editor with css.
So I modified it so that the theme of ace editor can be specified from the settings.
Let us hear what you think?
Solves #936
examples
settings.aceTheme = 'solarized_light'settings.aceTheme = 'solarized_dark'settings.aceTheme = 'tomorrow_night_bright'