Skip to content

Commit

Permalink
Fix expose field for external modules and builtins
Browse files Browse the repository at this point in the history
  • Loading branch information
ElNounch committed Apr 9, 2015
1 parent 4d6479a commit 0806001
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 8 deletions.
19 changes: 11 additions & 8 deletions index.js
Expand Up @@ -143,14 +143,17 @@ Browserify.prototype.require = function (file, opts) {
}));
return this;
}

var row = typeof file === 'object'
? xtend(file, opts)
: (isExternalModule(file)
? xtend(opts, { id: expose || file })
: xtend(opts, { file: file })
)
;

var row;
if (typeof file === 'object') {
row = xtend(file, opts);
} else if (isExternalModule(file)) {
// external module or builtin
row = xtend(opts, { id: expose || file, file: file });
} else {
row = xtend(opts, { file: file });
};

if (!row.id) {
row.id = expose || file;
}
Expand Down
26 changes: 26 additions & 0 deletions test/require_expose.js
Expand Up @@ -2,6 +2,32 @@ var browserify = require('../');
var test = require('tap').test;
var vm = require('vm');

test('require expose external module', function (t) {
t.plan(2);

var b = browserify({ basedir: __dirname });
b.require('beep', { expose: 'bip' });
b.bundle(function (err, src) {
t.ifError(err);
var c = { };
vm.runInNewContext(src, c);
t.equal(c.require('bip'), 'boop');
})
});

test('renaming builtin', function (t) {
t.plan(2);

var b = browserify({ basedir: __dirname });
b.require('os', { expose: 'bone' });
b.bundle(function (err, src) {
t.ifError(err);
var c = { };
vm.runInNewContext(src, c);
t.equal(c.require('bone').platform(), 'browser');
})
});

test('exposed modules do not leak across bundles', function (t) {
var bundle1, bundle2;

Expand Down

0 comments on commit 0806001

Please sign in to comment.