Skip to content

Commit

Permalink
Merge pull request #1273 from substack/housekeeping
Browse files Browse the repository at this point in the history
Housekeeping
  • Loading branch information
zertosh committed May 20, 2015
2 parents b065829 + 3842880 commit fbaee6e
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 20 deletions.
7 changes: 0 additions & 7 deletions bin/args.js
Original file line number Diff line number Diff line change
Expand Up @@ -245,13 +245,6 @@ module.exports = function (args, opts) {
return b;
};

function copy (obj) {
return Object.keys(obj).reduce(function (acc, key) {
acc[key] = obj[key];
return acc;
}, {});
}

function splitOnColon (f) {
var pos = f.lastIndexOf(':');
if (pos == -1) {
Expand Down
8 changes: 0 additions & 8 deletions bin/cmd.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,6 @@ else {
bundle.pipe(process.stdout);
}

function packageFilter (info) {
if (info && typeof info.browserify === 'string' && !info.browser) {
info.browser = info.browserify;
delete info.browserify;
}
return info || {};
}

function errorExit(err) {
if (err.stack) {
console.error(err.stack);
Expand Down
6 changes: 2 additions & 4 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,10 @@ var builtins = require('./lib/builtins.js');
var splicer = require('labeled-stream-splicer');
var through = require('through2');
var concat = require('concat-stream');
var duplexer = require('duplexer2');

var inherits = require('inherits');
var EventEmitter = require('events').EventEmitter;
var xtend = require('xtend');
var copy = require('shallow-copy');
var isarray = require('isarray');
var defined = require('defined');
var has = require('has');
Expand Down Expand Up @@ -423,7 +421,7 @@ Browserify.prototype._createPipeline = function (opts) {

Browserify.prototype._createDeps = function (opts) {
var self = this;
var mopts = copy(opts);
var mopts = xtend(opts);
var basedir = defined(opts.basedir, process.cwd());

// Let mdeps populate these values since it will be resolving file paths
Expand Down Expand Up @@ -503,7 +501,7 @@ Browserify.prototype._createDeps = function (opts) {
else if (opts.builtins && typeof opts.builtins === 'object') {
mopts.modules = opts.builtins;
}
else mopts.modules = copy(builtins);
else mopts.modules = xtend(builtins);

Object.keys(builtins).forEach(function (key) {
if (!has(mopts.modules, key)) self._exclude.push(key);
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
"read-only-stream": "^1.1.1",
"readable-stream": "^1.1.13",
"resolve": "^1.1.4",
"shallow-copy": "0.0.1",
"shasum": "^1.0.0",
"shell-quote": "~0.0.1",
"stream-browserify": "^1.0.0",
Expand Down

0 comments on commit fbaee6e

Please sign in to comment.