-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages/paths in backticks (`) are ignored #1782
Comments
TehShrike
changed the title
Paths in backticks (`) are ignored
Packages/paths in backticks (`) are ignored
Dec 15, 2017
Yeah, I think this would make sense! |
TehShrike
added a commit
to TehShrike/node-browserify
that referenced
this issue
Dec 20, 2017
This was referenced Dec 20, 2017
Once browserify/detective#74 is merged and released, I'll update browserify/module-deps#136 with the version bump, and then once that is merged and released, I'll update #1785 |
Sweet! Should I update the changelog so that a new release can go out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Browserify resolves
tape
correctly here:but not here:
This differs from node's behavior.
Are you open to having this fixed? I'm willing to add tests and write the patch.
Context
I started using an eslint autoformat script with
quotes
set tobacktick
, so all of my strings are backtick-enclosed nowadays. (See also: https://ponyfoo.com/articles/template-literals-strictly-better-strings )The text was updated successfully, but these errors were encountered: