Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages/paths in backticks (`) are ignored #1782

Closed
TehShrike opened this issue Dec 15, 2017 · 3 comments
Closed

Packages/paths in backticks (`) are ignored #1782

TehShrike opened this issue Dec 15, 2017 · 3 comments

Comments

@TehShrike
Copy link
Contributor

Browserify resolves tape correctly here:

const test = require('tape')

but not here:

const test = require(`tape`)

This differs from node's behavior.


Are you open to having this fixed? I'm willing to add tests and write the patch.

Context

I started using an eslint autoformat script with quotes set to backtick, so all of my strings are backtick-enclosed nowadays. (See also: https://ponyfoo.com/articles/template-literals-strictly-better-strings )

@TehShrike TehShrike changed the title Paths in backticks (`) are ignored Packages/paths in backticks (`) are ignored Dec 15, 2017
@goto-bus-stop
Copy link
Member

Yeah, I think this would make sense!

TehShrike added a commit to TehShrike/node-browserify that referenced this issue Dec 20, 2017
@TehShrike
Copy link
Contributor Author

Once browserify/detective#74 is merged and released, I'll update browserify/module-deps#136 with the version bump, and then once that is merged and released, I'll update #1785

@TehShrike
Copy link
Contributor Author

Sweet! Should I update the changelog so that a new release can go out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants