Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test + fix for backtick quotes #1785

Merged
merged 2 commits into from Jan 4, 2018

Conversation

TehShrike
Copy link
Contributor

@TehShrike TehShrike commented Dec 20, 2017

Issue #1782

This issue needs to be fixed in module-deps. I will open a pull request there.

@goto-bus-stop
Copy link
Member

in https://github.com/browserify/detective even, i think. thanks for working on this :D

@TehShrike
Copy link
Contributor Author

I'll update this to use module-deps@2.x and then it should be good.

@TehShrike TehShrike changed the title Failing test for backtick quotes Failing test + fix for backtick quotes Jan 2, 2018
@TehShrike
Copy link
Contributor Author

Bumping the dependency on module-deps guarantees that the backtick-supporting version of detective will be used.

The tests fail in 0.10 and 0.12 because detective doesn't support those versions any more.

@goto-bus-stop
Copy link
Member

merging since the failures are only on node <4 and tests will pass on master. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants