Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readable-stream to v3 #1880

Open
goto-bus-stop opened this issue Nov 15, 2018 · 3 comments
Open

update readable-stream to v3 #1880

goto-bus-stop opened this issue Nov 15, 2018 · 3 comments
Assignees
Milestone

Comments

@goto-bus-stop
Copy link
Member

requires stream-browserify to be updated too.

@legobeat
Copy link

Addressed in #2070

@legobeat
Copy link

legobeat commented Sep 10, 2023

There is still a transitive runtime dependency on readable-stream@2, via read-only-stream.

Unfortunately, the author and sources are MIA from GitHub.

I see some conflicting information from the last snapshot from web.archive.org indicating a last commit of v2.0.0 (the published version of which still depends on readable-stream@2) whereas the last commit on index.js indicates "streamsv3".

The only remaining fork seems to be https://github.com/juliangruber/read-only-stream, which is missing those original and newer contributions.

On the other hand, the module is fairly small, readable, and not minified or anything so if it comes down to it, it doesn't seem untenable for someone else than substack to pick up the published version from the NPM registry and see what if anything beyond a change in package.json is needed to make it compatible with streamsv3.

@juliangruber

@ljharb
Copy link
Member

ljharb commented Sep 11, 2023

An alternative is that I could pursue going through github and substack to get the repo revived and the npm access turned over; i've done it for a dozen of substack's packages already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants