Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js removed the
buffer.toArrayBuffer()
API sometime during node 0.11. Users who rely on it will have code that doesn't work in node.js, which is unfortunate.feross/buffer
v4.0.0 removedbuffer.toArrayBuffer()
to have parity with node.js.Going forward, users can just use
buffer.buffer
to get anArrayBuffer
sinceBuffer
is just a subclass ofUint8Array
in both node.js and the browser.This is a breaking change, since we're removing a method from the buffer.
I'm only sending this PR now, since buffer v4.1.0 has a 30% performance increase for lots of the buffer methods and I want users to have that 馃憤