Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring transformKey option for module-deps #1670

Merged
1 commit merged into from Jan 4, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
Expand Up @@ -434,7 +434,7 @@ Browserify.prototype._createDeps = function (opts) {
self._extensions = mopts.extensions;

mopts.transform = [];
mopts.transformKey = [ 'browserify', 'transform' ];
mopts.transformKey = defined(opts.transformKey, [ 'browserify', 'transform' ]);
mopts.postFilter = function (id, file, pkg) {
if (opts.postFilter && !opts.postFilter(id, file, pkg)) return false;
if (self._external.indexOf(file) >= 0) return false;
Expand Down
17 changes: 17 additions & 0 deletions test/ignore_transform_key.js
@@ -0,0 +1,17 @@
var browserify = require('../');
var test = require('tap').test;
var vm = require('vm');

test('ignore transform', function(t) {
t.plan(1);

var b = browserify({
transformKey: false
});
b.add(__dirname + '/ignore_transform_key/main.js');

b.bundle(function(err, src) {
if (err) t.fail(err);
vm.runInNewContext(src, {t: t});
});
});
3 changes: 3 additions & 0 deletions test/ignore_transform_key/main.js
@@ -0,0 +1,3 @@
var a = require('a');

t.equal(a, 'good');
1 change: 1 addition & 0 deletions test/ignore_transform_key/node_modules/a/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions test/ignore_transform_key/node_modules/a/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions test/ignore_transform_key/node_modules/evil-transform/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.