Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node.js v8 to Travis CI #1743

Merged
merged 3 commits into from Jan 4, 2018

Conversation

ryysud
Copy link
Contributor

@ryysud ryysud commented Jul 2, 2017

Add support for Node.js v8.
Updated .travis.yml.

@hiroppy
Copy link

hiroppy commented Sep 2, 2017

I think we can drop 0.12 and 0.10.

@ryysud
Copy link
Contributor Author

ryysud commented Sep 2, 2017

@abouthiroppy I think so too.

@ryysud
Copy link
Contributor Author

ryysud commented Sep 2, 2017

Please follow up on this 🙇

@hiroppy
Copy link

hiroppy commented Sep 2, 2017

@substack @maxogden What do you think?

.travis.yml Outdated
@@ -1,8 +1,6 @@
language: node_js
node_js:
- "8"
- "7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove 7 and add 9?

@stevemao
Copy link
Member

stevemao commented Nov 1, 2017

Note this will be a breaking change

@ryysud
Copy link
Contributor Author

ryysud commented Nov 2, 2017

@stevemao I fix it.

@goto-bus-stop
Copy link
Member

@ryysud sorry for the wait, curious if you could check out the test failure? it looks like it's a bug in the traceur version used by the yield.js test, maybe bumping the es6ify dependency in our package.json could work?

@goto-bus-stop
Copy link
Member

i'll remove es6ify after merging. thanks for the patch!

@goto-bus-stop goto-bus-stop merged commit 3ccd552 into browserify:master Jan 4, 2018
@ryysud ryysud deleted the add-nodejs-v8-to-travis branch January 4, 2018 14:14
@ljharb
Copy link
Member

ljharb commented Jan 6, 2018

fwiw I think dropping node < 4 was a very very bad move, and I think that should be reverted.

@ryysud
Copy link
Contributor Author

ryysud commented Jan 9, 2018

@ljharb Sorry. Thank you for your Pull Request 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants