Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing tests on Windows and Node 10 #1819

Merged
merged 6 commits into from
May 8, 2018
Merged

Passing tests on Windows and Node 10 #1819

merged 6 commits into from
May 8, 2018

Commits on May 8, 2018

  1. Try adding appveyor

    @goto-bus-stop
    goto-bus-stop committed May 8, 2018
    Configuration menu
    Copy the full SHA
    2d896a9 View commit details
    Browse the repository at this point in the history

  2. Fix tests on Windows. 

     - Use path.join in more places in tests so they can run on windows

 - Fix noParse check on windows

 - Fix regex in multi_entry test for windows paths

 - Skip symlink tests on windows

 - Fix ignore check on windows

 - Fix paths in noparse and ignore tests on windows.
    @goto-bus-stop
    goto-bus-stop committed May 8, 2018
    Configuration menu
    Copy the full SHA
    c5120b7 View commit details
    Browse the repository at this point in the history

  3. Fix external relative paths on Windows 

    Replace backslashes with forward slashes when adding relative paths for
external references.
    @Shingyx @goto-bus-stop
    Shingyx authored and goto-bus-stop committed May 8, 2018
    Configuration menu
    Copy the full SHA
    c428f0c View commit details
    Browse the repository at this point in the history

  4. Skip failing test on old Node on Windows 

    Not sure why this is failing, and can't test it well, so skipping for
now with a TODO comment
    @goto-bus-stop
    goto-bus-stop committed May 8, 2018
    Configuration menu
    Copy the full SHA
    e39d609 View commit details
    Browse the repository at this point in the history

  5. Disable invalid json chars test in node 10

    @goto-bus-stop
    goto-bus-stop committed May 8, 2018
    Configuration menu
    Copy the full SHA
    3703154 View commit details
    Browse the repository at this point in the history

  6. Skip flaky test on Windows w old Node

    @goto-bus-stop
    goto-bus-stop committed May 8, 2018
    Configuration menu
    Copy the full SHA
    8e7cb87 View commit details
    Browse the repository at this point in the history