Update util to 0.12.4
#53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome 92 started to disable `SharedArrayBuffer` without cross-origin isolation which can be enabled by [sending the page with special HTTP headers](https://web.dev/cross-origin-isolation-guide/). This change causes Chrome to emit a warning in DevTools console and [developers are confused with the message](vercel/next.js#21708). `util` is one of the libraries that uses `SharedArrayBuffer` and is causing the warning to appear in the console. Luckily, the issue in `util` has been resolved in v0.12.4 and I would like to propose applying the fixed version to this library.
ljharb
reviewed
Aug 11, 2021
| "util": "^0.12.0" | ||
| "util": "^0.12.4" |
There was a problem hiding this comment.
this is fine, but is 100% unnecessary because of the ^ range. You can update to anything within 0.12.x with the range ^0.12.0, and anyone freshly installing this package will get the latest version of util automatically.
There was a problem hiding this comment.
Ah, I see. I found that next has its 0.12.3 in the package-lock.json that's probably why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome 92 started to disable
SharedArrayBufferwithout cross-origin isolation which can be enabled by sending the page with special HTTP headers. This change causes Chrome to emit a warning in DevTools console and developers are confused with the message.utilis one of the libraries that usesSharedArrayBufferand is causing the warning to appear in the console.Luckily, the issue in
utilhas been resolved in v0.12.4 and I would like to propose applying the fixed version to this library.