Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opts.expose object to populate resolved pathnames for exposed modules #65

Merged
3 commits merged into from
Feb 16, 2015

Conversation

jmm
Copy link
Collaborator

@jmm jmm commented Jan 17, 2015

This is to support related changes on browserify (browserify/browserify/pull/1077).

What's the logic for what properties from opts become this.something vs remaining accessible as this.options.something?

@jmm
Copy link
Collaborator Author

jmm commented Jan 19, 2015

What's the intent of this part?:

if (rec.expose) {
    self.options.modules[rec.expose] = file;
}

Before this pull and browserify/browserify/pull/1077 it means that the following gets the file treated as built in (e.g. transforms aren't run):

b.require('./somefile', {expose: './somefile'});

Whereas these are ok:

b.require('./somefile');
b.require('./somefile', {expose: 'whatever'});

After these pulls it means that this would also get the file treated as built in:

b.require('./somefile');

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant