Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests from npm package #308

Closed
wants to merge 1 commit into from
Closed

Remove tests from npm package #308

wants to merge 1 commit into from

Conversation

boidolr
Copy link

@boidolr boidolr commented Aug 15, 2023

Reduce package by removing tests from the published package (about 312kb from 424kb).

ljharb
ljharb requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, these are intentionally included and absolutely need to be in the published package - npm explore foo && npm install && npm test should always work. Those files must be included, and will forever be.

Note as well that this would be a breaking change.

@ljharb ljharb marked this pull request as draft August 15, 2023 18:47
@ljharb
Copy link
Member

ljharb commented Aug 15, 2023

Duplicate of #296. Duplicate of #281. Duplicate of #279. Duplicate of #239. Duplicate of #235. Duplicate of #58. Duplicate of #44. See #105 (comment).

@ljharb ljharb closed this Aug 15, 2023
@boidolr boidolr deleted the reduce-package-size branch August 15, 2023 19:01
This was referenced May 6, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boidolr @ljharb